-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 w/ TypeScript Overhaul #112
Conversation
Hey @JacobMGEvans, super cool to see a TypeScript re-write for wrangler-actions! Regarding #105, what do you think of adding a I would love to contribute if the idea swims well with you! |
Definitely wouldn't be against it. I was trying to make this quieter and cleaner (hence grouping) then before 😃 Probably will do that by default for Secrets too (just in case) |
Awesome! I have created a PR in #113 that addresses this. Please review it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much liking this 👀
nit: before merge can we get prettier added and code formatted akin to workers-sdk
? https://github.com/cloudflare/workers-sdk/blob/main/.prettierrc
@Cherry |
6192155
to
089567d
Compare
3f9b0f3
to
6e97c1c
Compare
6e97c1c
to
ad5698d
Compare
ad5698d
to
3f0c167
Compare
CHANGELOG.md
Outdated
|
||
### Breaking changes | ||
|
||
- Docker is no longer a dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Docker is no longer a dependency.
This isn't a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't 100% certain but I will take your word on it lol
3f0c167
to
ecace2e
Compare
After having upgraded I’m getting the following error. Error: File not found: '/opt/actions-runner/_work/_actions/cloudflare/wrangler-action/3.0.0/dist/index.js' We are using custom runners. Is there an additional step needed that I’m missing? |
4d72254
to
ff04a40
Compare
@NJordan72 Well the PR is not merged but with this new setup it uses Node for the runner in GH Actions. |
ff04a40
to
caf6976
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @JacobMGEvans !
caf6976
to
96a6683
Compare
* Removes dependencies such as Docker, decreasing spin-up time * Adds community-requested features, including bulk secrets API utilization from Wrangler * Fixes CI/CD * Adds testing * Improves command implementation * Begins using Node for the Action engine/runner * Openly discusses all changes with the community GitHub Discussions opened and Issues monitored BREAKING CHANGES: * Docker is no longer a dependency * Wrangler v1 is no longer supported Additional related Internal tickets: Major Version Default: https://jira.cfdata.org/browse/DEVX-632 Rewrite Project: DEVX-804,802,800,632
96a6683
to
edb2a58
Compare
Additional related Internal tickets:
Major Version Default: https://jira.cfdata.org/browse/DEVX-632
Rewrite Project: DEVX-804,802,800,632