Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move printWranglerBanner for secret delete into handler #7020

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KianNH
Copy link
Contributor

@KianNH KianNH commented Oct 18, 2024

What this PR solves / how to test

Moves the banner into the args handler like the rest of the commands as this command was printing the banner in the --help output.

➜  ~ npx wrangler secret delete --help

 ⛅️ wrangler 3.78.3 (update available 3.81.0)
-------------------------------------------------------

wrangler secret delete <key>

Delete a secret variable from a Worker

POSITIONALS
  key  The variable name to be accessible in the Worker  [string] [required]

GLOBAL FLAGS
  -j, --experimental-json-config  Experimental: support wrangler.json  [boolean]
  -c, --config                    Path to .toml configuration file  [string]
  -e, --env                       Environment to use for operations and .env files  [string]
  -h, --help                      Show help  [boolean]
  -v, --version                   Show version number  [boolean]

OPTIONS
      --name  Name of the Worker  [string]
➜  ~ npx wrangler secret put --help
wrangler secret put <key>

Create or update a secret variable for a Worker

POSITIONALS
  key  The variable name to be accessible in the Worker  [string] [required]

GLOBAL FLAGS
  -j, --experimental-json-config  Experimental: support wrangler.json  [boolean]
  -c, --config                    Path to .toml configuration file  [string]
  -e, --env                       Environment to use for operations and .env files  [string]
  -h, --help                      Show help  [boolean]
  -v, --version                   Show version number  [boolean]

OPTIONS
      --name  Name of the Worker  [string]

@KianNH KianNH requested a review from a team as a code owner October 18, 2024 13:46
Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: 96bc595

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11404944222/npm-package-wrangler-7020

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7020/npm-package-wrangler-7020

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11404944222/npm-package-wrangler-7020 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11404944222/npm-package-create-cloudflare-7020 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11404944222/npm-package-cloudflare-kv-asset-handler-7020
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11404944222/npm-package-miniflare-7020
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11404944222/npm-package-cloudflare-pages-shared-7020
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11404944222/npm-package-cloudflare-vitest-pool-workers-7020
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11404944222/npm-package-cloudflare-workers-editor-shared-7020
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11404944222/npm-package-cloudflare-workers-shared-7020

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241011.1 1.20241011.1
workerd --version 1.20241011.1 2024-10-11

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant