Add more helpful error messages when validating compatibility date #7002
Conversation
🦋 Changeset detectedLatest commit: 6eea915 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11391598061/npm-package-wrangler-7002You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7002/npm-package-wrangler-7002Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11391598061/npm-package-wrangler-7002 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11391598061/npm-package-create-cloudflare-7002 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11391598061/npm-package-cloudflare-kv-asset-handler-7002npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11391598061/npm-package-miniflare-7002npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11391598061/npm-package-cloudflare-pages-shared-7002npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11391598061/npm-package-cloudflare-vitest-pool-workers-7002npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11391598061/npm-package-cloudflare-workers-editor-shared-7002npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11391598061/npm-package-cloudflare-workers-shared-7002Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
GregBrimble
force-pushed
the
more-compat-date-validation
branch
from
e5e2db7
to
6eea915
Compare
| "wrangler": patch | ||
| --- | ||
|
|
||
| feat: More helpful error messages when validating compatibility date |
There was a problem hiding this comment.
| feat: More helpful error messages when validating compatibility date | |
| fix: More helpful error messages when validating compatibility date |
| return !isNaN(data.getTime()); | ||
| }; | ||
|
|
||
| const validateCompatibilityDate: ValidatorFn = (diagnostics, field, value) => { |
There was a problem hiding this comment.
let's make sure we surface all errors on first throw, as opposed to one per cmd run. See my comment here. It makes for a much better UX and it's something we're pushing for since recently.
validateAssetsConfig is a good example of how'd like things to work
| value.includes("—") // em-dash | ||
| ) { | ||
| diagnostics.errors.push( | ||
| `Hyphens (-) should be used rather than en-dashes (—) or em-dashes (–) in the "${field}" field.` |
There was a problem hiding this comment.
| `Hyphens (-) should be used rather than en-dashes (—) or em-dashes (–) in the "${field}" field.` | |
| `"${field}" field should use hyphens (-) rather than en-dashes (—) or em-dashes (–).` |
GregBrimble
force-pushed
the
more-compat-date-validation
branch
from
cbb4b61
to
6eea915
Compare
What this PR solves / how to test
Fixes WC-2854.
Author has addressed the following