C3: Validate project name

[jculvey]

Fixes #3222

What this PR solves / how to test:

This change ensures that project names are also valid pages project names to prevent crashes during the deploy step.

Associated docs issue(s)/PR(s):

• [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

• [ x ] Tests
• [ x ] Changeset (Changeset guidelines)

Reviewer is to perform the following, as applicable:

• Checked for inclusion of relevant tests
• Checked for inclusion of a relevant changeset
• Checked for creation of associated docs updates
• Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2dcc2ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6500478283/npm-package-wrangler-4128

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6500478283/npm-package-wrangler-4128

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6500478283/npm-package-wrangler-4128 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6500478283/npm-package-cloudflare-pages-shared-4128

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	3.20231010.0	3.20231010.0
workerd	1.20231010.0	1.20231010.0
workerd --version	1.20231010.0	2023-10-10

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

Merging #4128 (2fc9959) into main (0f043a1) will decrease coverage by 0.20%.
The diff coverage is n/a.

❗ Current head 2fc9959 differs from pull request most recent head 2dcc2ca. Consider uploading reports for the commit 2dcc2ca to get more accurate results

@@            Coverage Diff             @@
##             main    #4128      +/-   ##
==========================================
- Coverage   75.57%   75.38%   -0.20%     
==========================================
  Files         237      223      -14     
  Lines       12493    12201     -292     
  Branches     3196     3153      -43     
==========================================
- Hits         9442     9198     -244     
+ Misses       3051     3003      -48     

see 31 files with indirect coverage changes

[petebacondarwin]

LGTM - waiting on e2e tests to pass though...

[petebacondarwin]

E2E test failures seem to be legit?

[jculvey]

E2E test failures seem to be legit?

Turns out it was chatgptPlugin. Pages have stricter name requirements than do workers and was failing under the new validation despite previously working as a workers name. It would be nice if we could validate the name depending on the project type, but because of the dialog sequence that isn't really possible.