Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate cloudflare_list to terraform-plugin-framework #4228

Merged
merged 11 commits into from
Oct 8, 2024

Conversation

qjex
Copy link
Contributor

@qjex qjex commented Oct 7, 2024

This PR migrates the cloudflare_list resource to using the terraform-plugin-framework which internally addresses the zero value issues we've encountered with booleans and ints.

Tests

go test -v  -run ^TestAccCloudflareList_ github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/list
=== RUN   TestAccCloudflareList_Exists
--- PASS: TestAccCloudflareList_Exists (10.93s)
=== RUN   TestAccCloudflareList_UpdateDescription
--- PASS: TestAccCloudflareList_UpdateDescription (17.87s)
=== RUN   TestAccCloudflareList_Update
--- PASS: TestAccCloudflareList_Update (80.50s)
=== RUN   TestAccCloudflareList_UpdateIgnoreIPOrdering
--- PASS: TestAccCloudflareList_UpdateIgnoreIPOrdering (14.22s)
=== RUN   TestAccCloudflareList_RemoveInlineConfig
--- PASS: TestAccCloudflareList_RemoveInlineConfig (27.05s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/list     151.138s

Copy link
Contributor

github-actions bot commented Oct 7, 2024

changelog detected ✅

@qjex qjex force-pushed the list-framework-migration branch 2 times, most recently from f85142d to acf6395 Compare October 7, 2024 18:24
@qjex qjex marked this pull request as ready for review October 7, 2024 18:28
@jacobbednarz
Copy link
Member

acceptance tests all looking good here, thanks!

TF_ACC=1 go test ./internal/framework/service/list/ -v -run "^TestAccCloudflareList_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareList_Exists
--- PASS: TestAccCloudflareList_Exists (2.77s)
=== RUN   TestAccCloudflareList_UpdateDescription
--- PASS: TestAccCloudflareList_UpdateDescription (7.11s)
=== RUN   TestAccCloudflareList_Update
--- PASS: TestAccCloudflareList_Update (32.49s)
=== RUN   TestAccCloudflareList_UpdateIgnoreIPOrdering
--- PASS: TestAccCloudflareList_UpdateIgnoreIPOrdering (5.11s)
=== RUN   TestAccCloudflareList_RemoveInlineConfig
--- PASS: TestAccCloudflareList_RemoveInlineConfig (10.88s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/list	59.590s

@jacobbednarz jacobbednarz merged commit f8cda8c into cloudflare:master Oct 8, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.44.0 milestone Oct 8, 2024
Copy link
Contributor

This functionality has been released in v4.44.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants