Refactor and cleaup daphne and daphne_worker crates #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendess
requested review from
armfazh,
bhalleycf,
captain-mota,
chris-wood and
cjpatton
as code owners
mendess
force-pushed
the
mendess/cleanup-taskprov
branch
4 times, most recently
from
a73b374
to
2cad5b8
Compare
cjpatton
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Beautiful work. Only one blocker: Let's drop ed09478, as I strongly suspect we're going to want MockAggregator in the public API soon in order to support interop testing. This is especially important after we sunset daphne_worker (in the public repo).
| pub taskprov_version: TaskprovVersion, | ||
| /// Is the taskprov extension allowed and which taskprov draft should be used? | ||
| #[serde(default)] | ||
| pub taskprov_version: Option<TaskprovVersion>, |
There was a problem hiding this comment.
Don't forget to make the corresponding change to the testing/staging/prod configs.
oliy
reviewed
Sep 26, 2023
oliy
reviewed
Sep 26, 2023
| @@ -162,7 +162,16 @@ pub trait DapLeader<S>: DapAuthorizedSender<S> + DapAggregator<S> { | |||
| .map_err(|e| DapAbort::from_codec_error(e, task_id.clone()))?; | |||
| debug!("report id is {}", report.report_metadata.id); | |||
|
|
|||
| resolve_taskprov(self, task_id, req, Some(&report.report_metadata)).await?; | |||
| if let Some(taskprov_version) = self.get_global_config().taskprov_version { | |||
There was a problem hiding this comment.
if you are checking this for every use of resolve_taskprov, maybe move the check into resolve_taskprov itself?
There was a problem hiding this comment.
I thought about that, the reason I kept it out is:
- in roles/helper.rs you'd have to check twice
- you can't forget to check because you need the value inside the option to call
resolve_taskprov
mendess
force-pushed
the
mendess/cleanup-taskprov
branch
from
2cad5b8
to
667f81a
Compare
mendess
force-pushed
the
mendess/cleanup-taskprov
branch
from
667f81a
to
d7eca8b
Compare
mendess
force-pushed
the
mendess/cleanup-taskprov
branch
from
d7eca8b
to
55fe71e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of mostly unrelated commits that clean up the codebase a
bit, they should be reviewed individually instead of as a single unit.