Reorganize daphne_worker #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendess
requested review from
armfazh,
bhalleycf,
captain-mota,
chris-wood and
cjpatton
as code owners
mendess
force-pushed
the
mendess/reorganize-daphne-worker
branch
from
a37342e
to
90a0b95
Compare
mendess
force-pushed
the
mendess/reorganize-daphne-worker
branch
from
90a0b95
to
e0fa341
Compare
cjpatton
reviewed
Aug 3, 2023
daphne/src/roles/leader.rs
Outdated
| resp_media_type: DapMediaType, | ||
| resource: DapResource, | ||
| req_data: Vec<u8>, | ||
| is_put: bool, |
There was a problem hiding this comment.
If set, this PUTs instead of POSTs. Since we're changing this code, we might as well rename it to be more accurate. How about "leader_send_http_request" and "LeaderHttpRequestOptions"?
daphne_worker/src/durable/mod.rs
Outdated
| req: Request, | ||
| state: &State, | ||
| env: &Env, | ||
| deployment: crate::config::DaphneWorkerDeployment, |
There was a problem hiding this comment.
- Suggestion:
staet,env,deployment, andtouchedare attributes common to all DOs that are "garbage collected". WDYTA about defining a trait for these and haverun_garbage_collectionbe a derived method on this trait? I think this would make the code a lot cleaner. - This doesn't actually "run" garbage collection: It puts the DO instance on the garbage collection queue, which is dequeued before each e2e tests.
There was a problem hiding this comment.
To be clear: The second suggestion is to rename the method.
mendess
force-pushed
the
mendess/reorganize-daphne-worker
branch
from
a723785
to
5fa4693
Compare
cjpatton
approved these changes
Aug 3, 2023
daphne/src/roles/leader.rs
Outdated
| path, | ||
| req_media_type, | ||
| resp_media_type, | ||
| resource, | ||
| req_data, | ||
| is_put, | ||
| method: is_put, |
| .await? | ||
| { | ||
| ControlFlow::Continue(req) => req, | ||
| // this req was a GC request and as such we must return from this funcition. |
There was a problem hiding this comment.
Suggested change
| // this req was a GC request and as such we must return from this funcition. | |
| // This req was a GC request and as such we must return from this function. |
| &self.state | ||
| } | ||
|
|
||
| fn deployment(&self) -> crate::config::DaphneWorkerDeployment { |
There was a problem hiding this comment.
nit: It would be slightly more general to return a reference to self..config, i.e., change the signature here to config(&self) -> &Confg (I forget the name of the actual type at the meoment)
mendess
force-pushed
the
mendess/reorganize-daphne-worker
branch
2 times, most recently
from
5bf7976
to
6fdeca3
Compare
Macros make the code harder to read as there are no types inside a macro body. They are also harder to debug and auto compleation doesn't work inside them.
mendess
force-pushed
the
mendess/reorganize-daphne-worker
branch
from
6fdeca3
to
11e3e17
Compare
mendess
force-pushed
the
mendess/reorganize-daphne-worker
branch
from
11e3e17
to
c0272cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the codebase a bit more by:
This PR is best viewed one commit at a time!