Implement the ping-pong flow #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the new aggregation flow as of DAP spec PR ietf-wg-ppm/draft-ietf-ppm-dap#393. This PR introduces the following changes: * In the current "leader-as-broadcast-channel" flow, the Leader gathers each round of prep shares from the Helpers, computes the prep message, and broadcasts it to the Helpers in the next round. In the new flow, we assume there is exactly one Helper, and each Aggregator runs the prep process as far as it it can until it needs input from its peer. This results in a significant reduction in the number of HTTP requests sent. * The `Report` serialization has changed in light of specializing the protocol for two Aggregators. * A new `PrepareStepState` variant is defined for signaling commitment to the share and transmitting the prep message. TODO List the code changs that were needed. We've tried to maintain test coverage, however some tests are no longer relevant since (a) we only support 1-round VDAFs and (b) draft04 requires one request to complete aggregation instead of two.
cjpatton
force-pushed
the
cjpatton/350/1/bump
branch
from
d913ce7
to
35efbf8
Compare
|
Superseded by #409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP (not ready for review).
Based on #351 (merge that first).
Partially addresses #350.