Add extra Azure parameters to cloudera.cloud.dw_cluster #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmudge
reviewed
Mar 21, 2024
plugins/modules/dw_cluster.py
Outdated
| @@ -337,6 +392,14 @@ def main(): | |||
| private_load_balancer=dict(type='bool', default=False), | |||
| az_subnet=dict(type='str'), | |||
| az_enable_az=dict(type='bool'), | |||
| az_managed_identity=dict(type='str'), | |||
There was a problem hiding this comment.
With so many Azure-related options, might want to revisit nesting them within a key, like azure?
Signed-off-by: Jim Enright <[email protected]>
jimright
force-pushed
the
feature/azure_dw_extra_params
branch
from
3876678
to
db9137a
Compare
github-actions
bot
added
validated
Signed-off-by: Jim Enright <[email protected]>
github-actions
bot
added
validated
Signed-off-by: Jim Enright <[email protected]>
github-actions
bot
added
validated
wmudge
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires cloudera-labs/cdpy#85