Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to be semantic with egress type space naming #585

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Update tests to be semantic with egress type space naming #585

merged 1 commit into from
Nov 4, 2021

Conversation

apburnes
Copy link
Contributor

@apburnes apburnes commented Nov 4, 2021

In order to be consistent with naming via cloud-gov/cg-scripts#181, update the test space names to reflect the new space naming convention

Changes proposed in this pull request:

  • Change test space names to closed-egress, restricted-egress, public-egress

security considerations

None

@apburnes apburnes requested a review from a team November 4, 2021 18:53
ccostino
ccostino approved these changes Nov 4, 2021
View reviewed changes
Copy link

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @apburnes!

@apburnes apburnes merged commit ae40e7a into master Nov 4, 2021
@apburnes apburnes deleted the apb/semantic-egress-tests branch November 4, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccostino ccostino ccostino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apburnes @ccostino