Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests on pull request #77

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Oct 7, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding CI tests on a pull request. More context here

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Verified the workflow from the fork branch.

Signed-off-by: Vishnu Challa <[email protected]>
@shashank-boyapally
Copy link
Collaborator

just curious on the change since pull_request_target might run the tests in on the context of the main branch and not on the fork branch. Correct me if I'm missing something.

@vishnuchalla
Copy link
Collaborator Author

just curious on the change since pull_request_target might run the tests in on the context of the main branch and not on the fork branch. Correct me if I'm missing something.

It will run on every pull request raised from a fork to main/master branch in the mainstream repo.

@shashank-boyapally
Copy link
Collaborator

/lgtm

@vishnuchalla vishnuchalla merged commit 7e35dce into cloud-bulldozer:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants