Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found the following issue when using
jit_preloader
:If multiple records in a collection have the same record set for a
belongs_to
, which itself has ahas_many
association, thehas_many
association will end up having duplicate records assigned. When using ARspreload
, there are no duplicate records.I could reproduce this behaviour with a spec and was also able to fix it. However, I'm not 100% sure if my fix will add other side effects if there are actually duplicate records via
has_many through:
or similar setups.Maybe somebody else with better understanding of the gem itself can simply tell where to apply a fix without side effects.