g.Rect: performance improvement when using Manhattan router with Rect shapes #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shapes Rect.containsPoint is called many times with a Point instance as argument. Avoiding the new Point call improves loading times significantly on larger papers.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rect.containsPoint is called many times with a Point instance as argument. Avoiding the new Point() call improves loading times significantly on large papers.
Motivation and Context
Our app uses Manhattan router with shapes and links. We've had performance issues when loading a larger paper, due to the time spent performing layout. One of the issues was that the routing logic calls
Rect.containsPointmany, many times (thousands), and this function constructs a new Point every time it is called. But, the argument it gets is already a Point instance, so creating a copy just for the comparison is not necessary.