Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing oldunittests #370

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+20 −1,141
Open

Removing oldunittests #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/features_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ def test_network_link_read(self) -> None:
assert network_link.address == "123 Main St"
assert network_link.phone_number == "555-1234"
assert network_link.snippet.text == "This is a snippet"
assert bool(network_link.snippet)
assert network_link.description == "This is a description"
assert network_link.view.latitude == 37.0
assert network_link.view.longitude == -122.0
Expand Down
19 changes: 19 additions & 0 deletions tests/helper_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
from fastkml.helpers import subelement_enum_kwarg
from fastkml.helpers import subelement_float_kwarg
from fastkml.helpers import subelement_int_kwarg
from fastkml.helpers import subelement_bool_kwarg
from tests.base import StdLibrary


Expand Down Expand Up @@ -126,3 +127,21 @@ def test_attribute_enum_kwarg(self) -> None:

assert res == {}
element.get.assert_called_once_with("nsnode")

def test_subelement_bool_kwarg(self) -> None:
node = Node()
node.text = ""
element = Mock()
element.find.return_value = node
res = subelement_bool_kwarg(
element=element,
ns="ns",
name_spaces={"name": "uri"},
node_name="node",
kwarg="a",
classes=(bool,),
strict=True,
)

assert res == {}
element.find.assert_called_once_with("nsnode")
Comment on lines +131 to +147
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider adding more comprehensive test cases.

While the basic test structure is good, consider enhancing the test coverage with:

  1. Test cases for different boolean values:
    • True/False values
    • Invalid boolean values
    • Error handling when strict=True
  2. Add a docstring explaining the test's purpose and test cases

Here's a suggested enhancement:

 def test_subelement_bool_kwarg(self) -> None:
+    """Test subelement_bool_kwarg function.
+    
+    Tests:
+    - Empty/None value handling
+    - Valid boolean values (True/False)
+    - Invalid values with strict mode
+    """
     # Test empty value
     node = Node()
     node.text = ""
     element = Mock()
     element.find.return_value = node
     res = subelement_bool_kwarg(
         element=element,
         ns="ns",
         name_spaces={"name": "uri"},
         node_name="node",
         kwarg="a",
         classes=(bool,),
         strict=True,
     )
     assert res == {}
     element.find.assert_called_once_with("nsnode")
+
+    # Test True value
+    node.text = "true"
+    res = subelement_bool_kwarg(
+        element=element,
+        ns="ns",
+        name_spaces={"name": "uri"},
+        node_name="node",
+        kwarg="a",
+        classes=(bool,),
+        strict=True,
+    )
+    assert res == {"a": True}
+
+    # Test False value
+    node.text = "false"
+    res = subelement_bool_kwarg(
+        element=element,
+        ns="ns",
+        name_spaces={"name": "uri"},
+        node_name="node",
+        kwarg="a",
+        classes=(bool,),
+        strict=True,
+    )
+    assert res == {"a": False}
+
+    # Test invalid value with strict mode
+    node.text = "invalid"
+    with pytest.raises(ValueError):
+        subelement_bool_kwarg(
+            element=element,
+            ns="ns",
+            name_spaces={"name": "uri"},
+            node_name="node",
+            kwarg="a",
+            classes=(bool,),
+            strict=True,
+        )
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
def test_subelement_bool_kwarg(self) -> None:
node = Node()
node.text = ""
element = Mock()
element.find.return_value = node
res = subelement_bool_kwarg(
element=element,
ns="ns",
name_spaces={"name": "uri"},
node_name="node",
kwarg="a",
classes=(bool,),
strict=True,
)
assert res == {}
element.find.assert_called_once_with("nsnode")
def test_subelement_bool_kwarg(self) -> None:
"""Test subelement_bool_kwarg function.
Tests:
- Empty/None value handling
- Valid boolean values (True/False)
- Invalid values with strict mode
"""
# Test empty value
node = Node()
node.text = ""
element = Mock()
element.find.return_value = node
res = subelement_bool_kwarg(
element=element,
ns="ns",
name_spaces={"name": "uri"},
node_name="node",
kwarg="a",
classes=(bool,),
strict=True,
)
assert res == {}
element.find.assert_called_once_with("nsnode")
# Test True value
node.text = "true"
res = subelement_bool_kwarg(
element=element,
ns="ns",
name_spaces={"name": "uri"},
node_name="node",
kwarg="a",
classes=(bool,),
strict=True,
)
assert res == {"a": True}
# Test False value
node.text = "false"
res = subelement_bool_kwarg(
element=element,
ns="ns",
name_spaces={"name": "uri"},
node_name="node",
kwarg="a",
classes=(bool,),
strict=True,
)
assert res == {"a": False}
# Test invalid value with strict mode
node.text = "invalid"
with pytest.raises(ValueError):
subelement_bool_kwarg(
element=element,
ns="ns",
name_spaces={"name": "uri"},
node_name="node",
kwarg="a",
classes=(bool,),
strict=True,
)

Loading
Loading