Merge branch '352-improve-test-coverage' into 361-test-geometries-wit…

…h-hypothesis

tests/containers_test.py

@@ -17,9 +17,10 @@
 """Test the kml classes."""
 
 
-from fastkml import kml
+from fastkml import kml, containers, features
 from tests.base import Lxml
 from tests.base import StdLibrary
+import pytest
 
 
 class TestStdLibrary(StdLibrary):
@@ -65,6 +66,38 @@ def test_document_boolean_visibility_invalid(self) -> None:
         assert d.features[0].visibility is None
         assert d.features[0].isopen
 
+    def test_container_creation(self) -> None:
+        container = containers._Container(
+            ns="ns",
+            id="id",
+            target_id="target_id",
+            name="name"
+        )
+        assert container.ns == "ns"
+        assert container.name == "name"
+
+    def test_container_feature_append(self) -> None:
+        container = containers._Container(
+            ns="ns",
+            id="id",
+            target_id="target_id",
+            name="name"
+        )
+        feature = features._Feature(name="new_feature")
+        container.append(feature)
+        assert feature in container.features
+        with pytest.raises(ValueError, match="Cannot append self"):
+            container.append(container)
+
+    def test_document_container_get_style_url(self) -> None:
+        document = containers.Document(
+            name="Document",
+            ns="ns",
+            style_url="www.styleurl.com"
+        )
+        assert document.get_style_by_url(style_url="www.styleurl.com") is None
+
+
 
 class TestLxml(Lxml, TestStdLibrary):
     """Test with lxml."""

tests/geometries/boundaries_test.py

@@ -16,6 +16,8 @@
 
 """Test the Outer and Inner Boundary classes."""
 
+import pytest
+from fastkml.exceptions import GeometryError
 import pygeoif.geometry as geo
 
 from fastkml.geometry import Coordinates
@@ -73,6 +75,24 @@ def test_inner_boundary(self) -> None:
             "</kml:coordinates></kml:LinearRing></kml:innerBoundaryIs>"
         )
 
+    def _test_boundary_geometry_error(self, boundary_class):
+        p = geo.Point(1, 2)
+        coords = ((1, 2), (2, 0), (0, 0), (1, 2))
+
+        with pytest.raises(GeometryError):
+            boundary_class(
+                kml_geometry=LinearRing(kml_coordinates=Coordinates(coords=coords)),
+                geometry=p
+            )
+
+    def test_outer_boundary_geometry_error(self):
+        """Test that OuterBoundaryIs raises GeometryError with invalid geometry."""
+        self._test_boundary_geometry_error(OuterBoundaryIs)
+
+    def test_inner_boundary_geometry_error(self):
+        """Test that InnerBoundaryIs raises GeometryError with invalid geometry."""
+        self._test_boundary_geometry_error(InnerBoundaryIs)
+
     def test_read_inner_boundary_multiple_linestrings(self) -> None:
         """
         Test the from_string method.

tests/geometries/functions_test.py

@@ -0,0 +1,71 @@
+from unittest.mock import Mock, patch
+import pytest
+from fastkml.exceptions import KMLParseError, KMLWriteError
+from fastkml.geometry import handle_invalid_geometry_error
+from fastkml.geometry import coordinates_subelement
+from tests.base import StdLibrary
+
+
+class TestGeometryFunctions(StdLibrary):
+    """Test functions in Geometry"""
+
+    @patch('fastkml.config.etree.tostring')
+    def test_handle_invalid_geometry_error_true(self, mock_to_string) -> None:
+        mock_element = Mock()
+        with pytest.raises(KMLParseError):
+            handle_invalid_geometry_error(
+                error=ValueError,
+                element=mock_element,
+                strict=True
+            )
+
+    @patch('fastkml.config.etree.tostring')
+    def test_handle_invalid_geometry_error_false(self, mock_to_string) -> None:
+        mock_element = Mock()
+        assert handle_invalid_geometry_error(
+            error=ValueError,
+            element=mock_element,
+            strict=False
+        ) is None
+
+    def test_coordinates_subelement_exception(self) -> None:
+        obj = Mock()
+        setattr(obj,
+                'coordinates',
+                [(1.123456, 2.654321, 3.111111, 4.222222)]
+            )
+
+        element = Mock()
+
+        precision = None
+        attr_name = 'coordinates'
+
+        with pytest.raises(KMLWriteError):
+            coordinates_subelement(
+                obj=obj,
+                attr_name=attr_name,
+                node_name=None,
+                element=element,
+                precision=precision,
+                verbosity=None,
+                default=None
+            )
+
+    def test_coordinates_subelement_getattr(self) -> None:
+        obj = Mock()
+        setattr(obj, 'coordinates', [(1.123456, 2.654321), (3.123456, 4.654321)])
+
+        element = Mock()
+
+        precision = 4
+        attr_name = 'coordinates'
+
+        assert coordinates_subelement(
+                obj=None,
+                attr_name=attr_name,
+                node_name=None,
+                element=element,
+                precision=precision,
+                verbosity=None,
+                default=None
+            ) is None

tests/geometries/linestring_test.py

@@ -21,8 +21,8 @@
 
 from fastkml import exceptions
 from fastkml.enums import Verbosity
-from fastkml.exceptions import KMLParseError
-from fastkml.geometry import LineString
+from fastkml.exceptions import GeometryError, KMLParseError
+from fastkml.geometry import Coordinates, LineString
 from tests.base import Lxml
 from tests.base import StdLibrary
 
@@ -38,6 +38,14 @@ def test_init(self) -> None:
         assert line_string.altitude_mode is None
         assert line_string.extrude is None
 
+    def test_geometry_error(self) -> None:
+        """Test GeometryError."""
+        p = geo.Point(1, 2)
+        q = Coordinates(ns="ns")
+
+        with pytest.raises(GeometryError):
+            LineString(geometry=p, kml_coordinates=q)
+
     def test_to_string(self) -> None:
         """Test the to_string method."""
         ls = geo.LineString(((1, 2), (2, 0)))

tests/geometries/multigeometry_test.py

@@ -15,10 +15,12 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
 
 """Test the geometry classes."""
+import pytest
+from fastkml.exceptions import GeometryError
 import pygeoif.geometry as geo
 
 from fastkml.enums import Verbosity
-from fastkml.geometry import MultiGeometry
+from fastkml.geometry import Coordinates, MultiGeometry
 from tests.base import Lxml
 from tests.base import StdLibrary
 
@@ -295,6 +297,14 @@ def test_multi_geometries_verbose(self) -> None:
         assert xml.count("extrude>0<") == 13
         assert xml.count("altitudeMode>clampToGround<") == 13
 
+    def test_geometry_error(self) -> None:
+        """Test GeometryError."""
+        p = geo.Point(1, 2)
+        q = Coordinates(ns="ns")
+
+        with pytest.raises(GeometryError):
+            MultiGeometry(geometry=p, kml_geometries=q)
+
     def test_multi_geometries_read(self) -> None:
         xml = (
             '<MultiGeometry xmlns="http://www.opengis.net/kml/2.2">'

tests/geometries/point_test.py

@@ -20,8 +20,9 @@
 import pytest
 
 from fastkml.enums import Verbosity
-from fastkml.exceptions import KMLParseError
+from fastkml.exceptions import GeometryError, KMLParseError
 from fastkml.geometry import Point
+from fastkml.geometry import Coordinates
 from tests.base import Lxml
 from tests.base import StdLibrary
 
@@ -39,6 +40,15 @@ def test_init(self) -> None:
         assert point.altitude_mode is None
         assert point.extrude is None
 
+    def test_geometry_error(self) -> None:
+        """Test GeometryError."""
+        p = geo.Point(1, 2)
+        q = Coordinates(ns="ns")
+
+        with pytest.raises(GeometryError):
+            Point(geometry=p, kml_coordinates=q)
+
+
     def test_to_string_2d(self) -> None:
         """Test the to_string method."""
         p = geo.Point(1, 2)

tests/geometries/polygon_test.py

@@ -16,6 +16,8 @@
 
 """Test the geometry classes."""
 
+import pytest
+from fastkml.exceptions import GeometryError
 import pygeoif.geometry as geo
 
 from fastkml.enums import AltitudeMode
@@ -127,6 +129,14 @@ def test_to_string_verbose_none(self) -> None:
 
         assert "extrude>0</" in polygon.to_string(verbosity=Verbosity.verbose)
 
+    def test_geometry_error(self) -> None:
+        """Test GeometryError."""
+        poly = geo.Polygon([(0, 0), (0, 1), (1, 1), (1, 0), (0, 0)])
+        ob = OuterBoundaryIs(ns="")
+
+        with pytest.raises(GeometryError):
+            Polygon(geometry=poly, outer_boundary=ob)
+
     def test_from_string_exterior_only(self) -> None:
         """Test exterior only."""
         doc = """<kml:Polygon xmlns:kml="http://www.opengis.net/kml/2.2">

tests/gx_test.py

@@ -51,6 +51,13 @@ def test_track(self) -> None:
             "coordinates": ((0.0, 0.0), (1.0, 1.0)),
         }
 
+    def test_track_etree_element(self) -> None:
+        g = Track()
+
+        g.etree_element()
+
+        assert g.track_items == []
+
     def test_multitrack(self) -> None:
         doc = """
         <gx:MultiTrack xmlns:kml="http://www.opengis.net/kml/2.2"
@@ -330,6 +337,8 @@ def test_from_multilinestring(self) -> None:
 
         mt = MultiTrack(geometry=lines, ns="")
 
+        assert bool(mt)
+
         assert (
             mt.to_string()
             == MultiTrack(