Added image proc as container #27
Conversation
| @@ -65,29 +73,65 @@ def generate_launch_description(): | |||
| parameters=[parameters, {'parameter_file': param_mapping_file,}], | |||
| output='screen', | |||
| remappings=[ | |||
| ('flir_blackfly/camera_info', 'color/camera_info'), | |||
| ('flir_blackfly/camera_info', 'camera_info'), | |||
There was a problem hiding this comment.
In our API documentation camera_info is indicated to be found at sensors/camera_#/color/camera_info so perhaps we need to revisit that documentation.
There was a problem hiding this comment.
@hilary-luo it is namespaced above:
arg_namespace = DeclareLaunchArgument(
'namespace',
default_value='platform/sensors/camera_0')
There was a problem hiding this comment.
That namespacing doesn't bring in the color section, that's all I was referring to.
There was a problem hiding this comment.
Ah, yes! I believe the API documentation should be updated.
There was a problem hiding this comment.
I thought about this too, the issue is that camera_info is published by the driver and used by all subsequent post-processing images. So, it makes sense to have it at the top level.
| 'blackfly_s.yaml' | ||
| FindPackageShare('spinnaker_camera_driver'), | ||
| 'config', | ||
| 'blackfly_s.yaml' | ||
| ])) | ||
|
|
||
| arg_namespace = DeclareLaunchArgument( | ||
| 'namespace', | ||
| default_value='platform/sensors/camera_0') |
There was a problem hiding this comment.
This should be sensors/camera_0 based on https://docs.clearpathrobotics.com/docs/ros/api/sensors_api
No description provided.