Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use licenseRefLookup to normalize license expression #1202

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Use licenseRefLookup to normalize license expression #1202

merged 1 commit into from
Oct 16, 2024

Conversation

qtomlinson
Copy link
Collaborator

No description provided.

ljones140
ljones140 reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ljones140 ljones140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see the recursion removed in favour of the SPDX package.

Happy to approve.

Do we need to issue a release for the package and update it in the service first?

As releases are tied to the GH package

@qtomlinson qtomlinson marked this pull request as ready for review October 16, 2024 18:16
@qtomlinson qtomlinson marked this pull request as draft October 16, 2024 18:22
@qtomlinson
Copy link
Collaborator Author

qtomlinson commented Oct 16, 2024 •
edited
Loading

@ljones140 Thanks for the feedback!
clearlydefined/spdx-expression-parse.js#9 has to be merged first, then clearlydefined/spdx#34 can be merged and released.

I will merge this PR to #1148 and then upgrade @clearlydefined/spdx in #1148

elrayle
elrayle approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @qtomlinson and @yashkohli88 for all their work to push the scancode LicenseRef code through to completion!!!

lib/utils.js
if (result === 'NOASSERTION') logger.info(`ScanCode NOASSERTION from ${rawLicenseExpression}`)

return result
}

function _normalizeParsedLicenseExpression(parsedLicenseExpression, logger) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good to see this move into the parser. Thanks for making this happen!

@qtomlinson qtomlinson marked this pull request as ready for review October 16, 2024 22:23
@qtomlinson qtomlinson merged commit 4fbdc2c into clearlydefined:add-licenseref-support Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljones140 ljones140 ljones140 left review comments

@elrayle elrayle elrayle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qtomlinson @elrayle @ljones140