Fix up gauge plotting for storm surge #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a couple of minor bugs related to gauge plotting. Major change involves how we now plot the gauge data.
|
One thing this reminded me of was that we still do not allow a long gauge id as mentioned in #541. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally fixes an errant line that showed up sometimes. This ended up a result of the gauge plots always plotting data unless a plot type
1d_emptyis used. Instead this usestime_scaleto convert from seconds to days so it should match better with other plots. The Isaac example also now includes an example of how to fetch and plot observed data.