Skip to content

Commit

Permalink
Removing uninitialized symbolic state specialization
Browse files Browse the repository at this point in the history
  • Loading branch information
ckirsch committed May 25, 2024
1 parent e08bb50 commit 9925051
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions tools/rotor.c
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ uint64_t print_constraint(uint64_t nid, uint64_t* line);

void print_comment(uint64_t* line);

uint64_t has_uninitialized_symbolic_state(uint64_t* line);
uint64_t has_symbolic_state(uint64_t* line);

uint64_t print_line_with_given_nid(uint64_t nid, uint64_t* line);
Expand Down Expand Up @@ -3736,14 +3735,10 @@ void print_comment(uint64_t* line) {
w = w + dprintf(output_fd, "\n");
}

uint64_t has_uninitialized_symbolic_state(uint64_t* line) {
return get_symbolic(line) == SYMBOLIC;
}

uint64_t has_symbolic_state(uint64_t* line) {
if (line == UNUSED)
return 0;
else if (has_uninitialized_symbolic_state(line))
else if (get_symbolic(line) == SYMBOLIC)
return 1;
else if (get_op(line) == OP_INPUT)
return inputs_are_symbolic;
Expand Down Expand Up @@ -4509,7 +4504,7 @@ uint64_t eval_read(uint64_t* line) {
}

if (get_sid(state_nid) == SID_CODE_STATE)
if (has_uninitialized_symbolic_state(state_nid))
if (get_symbolic(state_nid) == SYMBOLIC)
// avoid reading illegal instruction from uninitialized code segment
set_state(line, 1);

Expand Down

0 comments on commit 9925051

Please sign in to comment.