Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract request with retry to a stateless function #170

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhangyouxin
Copy link
Contributor

What Changed

This PR refactors extract ownership backend fetch request with retry and timeout to a stateless function. And changed corresponding test case.

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@zhangyouxin zhangyouxin changed the title [refactor]: extract request with retry to a stateless function refactor: extract request with retry to a stateless function Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #170 (0e4f3d4) into main (ad56928) will increase coverage by 0.11%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   86.79%   86.91%   +0.11%     
==========================================
  Files          40       41       +1     
  Lines         765      772       +7     
  Branches       94       94              
==========================================
+ Hits          664      671       +7     
  Misses         20       20              
  Partials       81       81              
Impacted Files Coverage Δ
...n-chrome/src/services/ownership/backend/request.ts 91.66% <91.66%> (ø)
...ome/src/services/ownership/backend/backendUtils.ts 91.66% <100.00%> (+1.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant