Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Creating new experience issue #87

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

oktayla
Copy link

@oktayla oktayla commented Jul 28, 2024

Description

Fix: Ensure Level ID is retrieved when adding points in GiveExperience trait

When the addPoints method in the GiveExperience trait is executed, it creates a new Experience. If the condition for the Level query returns null, the default level is retrieved from the config file. This update ensures that the Level ID is correctly retrieved in such cases.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related Issues and Pull Requests

  • Issue #...
  • PR #...

Testing

Please provide a passing test where possible. This package uses PestPHP

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation [OPTIONAL]

@cjmellor cjmellor added the bug Something isn't working label Aug 8, 2024
This reverts commit 0f5a6c1.
@cjmellor
Copy link
Owner

cjmellor commented Aug 8, 2024

@oktayla I think there is some failing tests on your changes. Can you check it?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants