-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the complete but empty example #207
base: v2.0.2beta
Are you sure you want to change the base?
Conversation
Nice catch. But perhaps the question should be here: should those 2 properties be mandatory? For And let's try to keep main branch the latest published, if we merge we should have a new branch v2.0.2 perhaps? |
Hm okay, then I would say make |
So that it is consistent with the appearances and metadata.
I made the two properties of the geometry-templates optional and I reverted to the initial example in the specs. Additionally, added a sentence that the six main Metadata properties are optional, because it was not explicit I thought. Could you check again @hugoledoux? |
…nal" This reverts commit 4454a4b.
I just realized that we are also bound by compatibility here, because if we make the two fields optional, that's a breaking change, since newly generated files might not have the previously required fields... |
The example of a complete but empty CityJSON object was invalid, because the
templates
andvertices-templates
members are mandatory ifgeometry-templates
is defined. Both members are arrays and they can be empty (but need to be present), just as in case of the rootvertices
member.