-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nightlies for pg15 #957
Conversation
since pg 15 coud not be downloaded for ol/7 from pgdg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we want to remove the workflow for enterprise, how about removing the word community from the single workflow we have left for Citus?
@@ -1,7 +1,7 @@ | |||
name: Build and publish citus community nightly packages | |||
|
|||
env: | |||
MAIN_BRANCH: "all-citus" | |||
MAIN_BRANCH: "all-citus-pg15-beta" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we intend to keep this change, or is it temporary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary. I will not merge the PR for all-citus-pg15-beta either. (#956)
# temporarily removed from nightlies since pg15 beta is not being downloaded for ol/7 | ||
# - ol/7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not create packages for all PG versions? If only PG15 does not work for ol/7 is there a way to disable only this combination?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no way for it now. I opened the PR in tools to be able to handle it
citusdata/tools#238
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is to enable nightlies without waiting the merge od this enablement PR. After merge of this PR there will be no need to disable ol/7 . We will just exclude pg15
I think we need more time for that. I've just removed community. Marlin still uses citus enterprise < 11. There may be some backports in the future for citus enterprise so it is too soon to make this changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont forget to revert back to all-citus branch before merging
No need to. We need pg 15 nightlies so all-citus-pg15-beta. I will revert back after citus will be ready without '--without-pg-version-check' flag |
Removed ol/7 since pg 15 could not be downloaded for ol/7. I'm working another PR to be able to exclude pg versions that is not being supported by os release pair. With this PR ol/7 nightlies could be baked for pg versions other than pg15
Note: With the approval of @metdos I removed both pgaf community and enterprise nightlies. Sİnce citus enterprise is not being used I removed it as well