Repairs and improvements for building with external dependencies #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionals to skip the submodule checks were using the wrong variable names, so the checks were always skipped. The correct behavior is to perform the check unless given `ZLIB=<zlib>` or `LZ4=<lz4>`, as applicable.
Supplying `ZUO=<zuo>` skips the submodule check in `configure` and configures the generated makefile not to build or remove Zuo.
For compatibility with older scripts, when not explicitly configured, continue to honor the `STEXLIB` environment variable at build time.
mflatt
approved these changes
Feb 27, 2024
|
This looks good to me. I'll wait a day or two before merging to see whether others detect an issue, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series repairs and improves support for configuring Chez Scheme to use external copies of some dependencies normally included as submodules. Overall, these changes let Chez Scheme be built in ways that already worked to build older versions of Chez Scheme and the copy of Chez Scheme distributed with Racket (because the configure script in the Racket sources tried less hard to make sure the dependencies were really present).
zlibandlz4submodules, which are currently noops, to actually perform checks unless configured withZLIB=<zlib>orLZ4=<lz4>, respectively.ZUO=<zuo>argument. Rather than simply skip the submodule check and require the user then to build withmake ZUO=zuo(or to use Zuo directly), this patch records the configuration choice inMf-configand slightly adjustsMakefile.into adapt more gracefully to this mode.STEXLIB=<stex>argument toconfigureand updatesbuild.zuoas I had considered in Guix-related build system enhancements racket/racket#4203 (comment) after racket/racket@d897379:In fact, with these changes cherry-picked as downstream patches, my draft update of the Guix package to Chez Scheme 10 is able to share its entire build recipe exactly with our
chez-scheme-for-racketpackage (which we used for the architectures newly supported in version 10 and will continue to use for bootstrapping).