Use GNU89 for kernel C #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C99/GNU99 is obviously well established and a sensible choice of standard for a C code base. Still, in some environments where it remains useful to compile Chez Scheme, the default `gcc` mode is GNU89. Since C isn't the main development language for Chez Scheme, since it's easy to stick to GNU89, and since that usefully reduces build friction, this commit makes the few changes needs to get back to GNU89. GitHub CI is configured to use `-std=gnu89` for two builds to help maintain the choice. GNU89 is a little more flexible than C89 (ANSI C), because it allows declarations in the middle of a block, but it does not allow variables defined in the parentheses after `for`. We also rely on GNU extensions for inlining declarations.
burgerrg
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C99/GNU99 is obviously well established and a sensible choice of standard for a C code base. Still, in some environments where it remains useful to compile Chez Scheme, the default
gccmode is GNU89.Since C isn't the main development language for Chez Scheme, since it's easy to stick to GNU89, and since that usefully reduces build friction, this commit makes the few changes needs to get back to GNU89. GitHub CI is configured to use
-std=gnu89for two builds to help maintain the choice.GNU89 is a little more flexible than C89 (ANSI C), because it allows declarations in the middle of a block, but it does not allow variables defined in the parentheses after
for. We also rely on GNU extensions for inlining declarations.The CI configuration here relies on #781, so this PR is a candidate for merging after that one.