Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update release notes on / and exact 0 #773

Merged
merged 1 commit into from
Dec 8, 2023
Merged

update release notes on / and exact 0 #773

merged 1 commit into from
Dec 8, 2023

Conversation

mflatt
Copy link
Contributor

@mflatt mflatt commented Nov 30, 2023

The release notes mentioned a change to the treatment of exact 0 as a divisor, but not as a dividend. The release notes now also point out that this change is not consistent with R6RS.

@jltaylor-us
Copy link
Contributor

According to #400 the idea was to preserve the r6rs behavior for the version of / exported from (rnrs), but that seems not to have happened.

@LiberalArtist LiberalArtist mentioned this pull request Dec 1, 2023
@johnwcowan
Copy link

I should think the Right Thing, if R6RS is wrong, to add this to the R6RS errata. In that case, the (rnrs) and (chezscheme) libraries can do the same thing.

The release notes mentioned a change to the treatment of exact 0 as a
divisor, but not as a dividend. The release notes now also point out
that this change is not consistent with R6RS.
@mflatt
Copy link
Contributor Author

mflatt commented Dec 2, 2023

According to #400 the idea was to preserve the r6rs behavior for the version of / exported from (rnrs), but that seems not to have happened.

True. My thinking is that adding r6rs:/is just more stuff and unlikely to matter to anyone, but it's straightforward to add if someone really wants it.

If it makes sense to amend R6RS to allow this, so much the better. I agree with Kent that we got this wrong.

That said, I'm surprised to discover that I long ago made Racket's R6RS layer stick to the current spec: https://github.com/racket/r6rs/blob/master/r6rs-lib/rnrs/base-6.rkt#L264

@mflatt
Copy link
Contributor Author

mflatt commented Dec 7, 2023

A proposal to move forward:

I'm happy to do that if there are no objections.

@mflatt mflatt merged commit e08dd75 into cisco:main Dec 8, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants