refine kernel compilation for threading modes #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a non-threaded machine type is specified directly without `--nothreads`, don't add C compiler flags for threading. Also, add more comments to `configure` to clarify the interplay of host machine and pb, and chekck for consistency of `--[no]threads` and an explicit machine type.
On a 32-bit platform, `ptr` is not the same as `void*` for tpb on a 32-bit platform, including Emscripten.
burgerrg
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is based on a suggestion from @owaddell. It changes
configureto infer threaded or non-threaded C flags when a machine type is supplied. It also adjustsconfigurein smaller ways to avoid mismatches between specified and inferred configurations related to threading.The second commit skips useless compilation of
gc-par.cfor non-threaded builds. This is done via the C preprocessor, instead of the makefile level, due to the way a non-threaded pb build may use a threaded host's configuration for compiling the kernel as a bootstrapping path.The third commit fixes a bug related to
S_make_mutexfor tpb, especially on a 32-bit platform such as Wasm via Emscripten.