repair char-foldcase for some single-character special cases
#740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerrg
requested changes
Oct 23, 2023
mats/5_4.ms
Outdated
| @@ -590,6 +590,9 @@ | |||
| (error? (char-foldcase 'a)) | |||
| (eqv? (char-foldcase #\a) #\a) | |||
| (eqv? (char-foldcase #\Z) #\z) | |||
| (eqv? (char-foldcase #\Z) #\z) | |||
There was a problem hiding this comment.
The #\Z case is a duplicate.
There was a problem hiding this comment.
Fixed in a new push - thanks!
For example, `(char-foldcase #\x1E9E)` should be `#\xDF`, in contrast to the `(string-foldcase (string #\x1E9E))` result of "ss". The character foldings that that are different here correspond to cases that are "S" status in "CaseFolding.txt". Thanks to Marc Feeley for noticing and reporting the bug. Also, repair some dependencies in "s/build.zuo".
burgerrg
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
(char-foldcase #\x1E9E)should be#\xDF, in contrast to the(string-foldcase (string #\x1E9E))result of "ss". The character foldings that that are different here correspond to cases that are "S" status in "CaseFolding.txt".Thanks to Marc Feeley for noticing and reporting the bug.
Also, repair some dependencies in "s/build.zuo".