Make testsuite emu/plugins/tdl pass on Go 1.20+
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought newer versions of Go weren't supposed to break existing code due to the backward compatibility promise. Well... |
Prior to Go 1.20 the pseudo-random number generator was seeded like Seed(1)
at program startup, but in later releases the generator is seeded randomly.
Since the testcase "typeDef1" uses the "rand" op the testcase output does
not always match the expected file: unit-test/exp/typeDef1.json
This is due to the different random order in Go 1.20+. By setting seed=1,
as previously done by Go itself, we get the same result in all Go version.
- Testcase
"params":
{
"size": 6,
"offset": 0,
"op": "rand",
"list": ["TRex", "Cisco", "Golang"]
}
- Go doc:
https://pkg.go.dev/math/rand@master#Seed
Signed-off-by: Björn Svensson <[email protected]>
bjosv
force-pushed
the
fix-tests-for-newer-golang
branch
from
8fd7744
to
758a91c
Compare
Yes, me too. I had to dig deep to find the reason as well.. |
|
I see that you changed organisation and user @bdollma-te, are you still a maintainer for trex-emu? |
|
Yes yes same person, simply multiple accounts and I commented with the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to Go 1.20 the pseudo-random number generator was seeded like Seed(1) at program startup, but in later releases the generator is seeded randomly.
Since the testcase
typeDef1uses therandoperation the testcase output does not always match the expected file:unit-test/exp/typeDef1.json.This is due to the different random order in Go 1.20+.
By setting seed=1 via its
TdlTestBase, as previously done by Go itself, we get the same result in all Go version.References:
Testcase:
"params": { "size": 6, "offset": 0, "op": "rand", "list": ["TRex", "Cisco", "Golang"] }Go doc: https://pkg.go.dev/math/rand@master#Seed