Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit hooks #183

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Update pre-commit hooks #183

merged 2 commits into from
Jun 6, 2024

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Jun 6, 2024

🗣 Description

This pull requests updates the pre-commit hooks in our configuration.

Note

The prettier hook is manually configured because of a limitation of how the pre-commit auto-generated mirrors-<tool> hooks are updated.

💭 Motivation and context

Regular updates are important! Also we need to update ansible-lint to support our Ansible roles because we need support for Fedora 40.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj
Update pre-commit hook versions
f51fe62 
This is done automatically with the `pre-commit autoupdate` command.
The pre-commit/mirrors-prettier was manually held back because the
latest tags are for alpha releases of the next major version.
@mcdonnnj
Manually update the prettier hook
8e55b8e 
Use the latest v3 release available from NPM.
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use dependencies Pull requests that update a dependency file labels Jun 6, 2024
@mcdonnnj mcdonnnj self-assigned this Jun 6, 2024
@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Jun 6, 2024
@mcdonnnj mcdonnnj added this pull request to the merge queue Jun 6, 2024
Merged via the queue into develop with commit de92c3c Jun 6, 2024
4 checks passed
@mcdonnnj mcdonnnj deleted the maintenance/update_pre-commit_hooks branch June 6, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@mcdonnnj mcdonnnj

Labels
dependencies Pull requests that update a dependency file improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r