Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of the crazy-max/ghaction-github-labeler Action and add a dependabot ignore directive #146

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request bumps the major version we pin for the crazy-max/ghaction-github-labeler Action from 4 to 5. It also adds a commented out dependabot ignore directive for this Action to the dependabot configuration file.

💭 Motivation and context

Keeping dependencies up-to-date is good. The ignore directive was missed when this Action was added to this repository and now downstream projects are getting hit with dependabot PRs.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Add crazy-max/ghaction-github-labeler as a commented out dependency to
ignore in the dependabot configuration file. This should be enabled in
downstream projects to consolidate updating this Action to the
cisagov/skeleton-generic repository.
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use dependencies Pull requests that update a dependency file github-actions Pull requests that update GitHub Actions code labels Sep 11, 2023
@mcdonnnj mcdonnnj self-assigned this Sep 11, 2023
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came to this repo just now to create this exact PR. You beat me to the punch!

@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Sep 12, 2023
@mcdonnnj mcdonnnj added this pull request to the merge queue Sep 13, 2023
Merged via the queue into develop with commit ca49bea Sep 13, 2023
3 checks passed
@mcdonnnj mcdonnnj deleted the improvement/update_labeler_action branch September 13, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Development

Successfully merging this pull request may close these issues.

3 participants