-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validator for writing sam. #278
Conversation
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 88.85% 90.10% +1.24%
==========================================
Files 78 80 +2
Lines 6496 7981 +1485
Branches 456 687 +231
==========================================
+ Hits 5772 7191 +1419
- Misses 268 316 +48
- Partials 456 474 +18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2a5754f
to
2343b68
Compare
f91ce3e
to
8a9dfd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating! 👍 👍
I've added some comments mostly on wording.
77820a6
to
f36a870
Compare
3f8a705
to
b1030cc
Compare
a19e9ba
to
9415ffe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the code, @niyarin!
LGTM 👍 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for reviewing so late🙇♂️
LGTM👍
I add sam1.0 validator for writing.
see also #271