Implemented dark variant

[azmeuk]

I took the color related CSS and made variables from them. The dark versions of those variables come from what DarkReader would have suggested.
The menu background image is disabled in dark mode.
I added the highlightjs github dark variant, so highlighted code also display well with dark theme.

The light theme should be unchanged.

I am not a designer so it is probably not perfect, but at least this is a start :)

Fixes #104.

[chrissimpkins]

Looks fantastic! Will you please explain how you are approaching the default and how one toggles between light and dark mode?

[azmeuk]

Generally, the system (Linux, MacOS, Windows, Android) has a dark/light preferences, that is passed to the browser. Depending on that preference, the browser will select properties to apply depending on prefers-color-scheme. There are ways to force a given mode in a browser with extensions like Dark reader.

At the moment cinder theme can only be switched by triggering that option from the browser, or the system.

What do you mean by approaching the default?

[chrissimpkins]

What do you mean by approaching the default?

I think that I misunderstood what you intended to support. So this automatically uses the user system setting for content theme. Is there a way to make this opt-in through our configuration in case existing users who upgrade want to keep the light mode color scheme for all users, irrespective of their system dark mode toggle setting?

[azmeuk]

So this automatically uses the user system setting for content theme.

Yes.

Is there a way to make this opt-in through our configuration in case existing users who upgrade want to keep the light mode color scheme for all users, irrespective of their system dark mode toggle setting?

Ok I'll have a look on how to do this.

[azmeuk]

@chrissimpkins before I tackle this, there might be another option to consider: we could display a switch that would toggle between light, dark, or system mode. Something like this. What do you think?

[chrissimpkins]

@chrissimpkins before I tackle this, there might be another option to consider: we could display a switch that would toggle between light, dark, or system mode. Something like this. What do you think?

Sure, let's try it. I'm interested to see what you have in mind.

Anyone out there who happens to be following this repo opposed?

[NotActuallyTerry]

Hello! A switch as described there, defaulting to System Default, feels like the way to go for implementing on-page control.

[chrissimpkins]

Hello! A switch as described there, defaulting to System Default, feels like the way to go for implementing on-page control.

Sgtm!

[fralfaro]

Hello, is this light/dark mode issue still valid?

[azmeuk]

I think so, I just cannot find anytime to improve the PR, so this probably need someone to pick it up!

[NotActuallyTerry]

From the looks of it, the feature got added in 60ae931 but this PR didn't get closed

[azmeuk]

Strangely this commit is neither in the master or dev branch: