Adds A Config Option To Provide a FontPath Substitution Map #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In order to A/B test fonts, this adds an option to the CalligraphyConfig to provide a fontPath substitution map. This enables dynamically changing fonts at run time and requires no changes to XML files. The logic to substitute the fontPath is in the TypefaceUtils. The reason the map is set on the TypeFaceUtils instead of the TypefaceUtils to checked the CalligraphyConfig is that this way it doesn't require constant invokations to CalligraphyConfig.get(). Test Plan: - Verified with sample app that the new config option works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In order to A/B test fonts, this adds an option to the
CalligraphyConfig to provide a fontPath substitution map.
This enables dynamically changing fonts at run time and requires
no changes to XML files.
The logic to substitute the fontPath is in the TypefaceUtils.
The reason the map is set on the TypeFaceUtils class instead of the
TypefaceUtils checking the CalligraphyConfig is that this way
it doesn't require constant invocations of CalligraphyConfig.get().
Test Plan: