Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Regular/Bold/Italic based on textStyle attribute #195

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

netmaxt3r
Copy link

No description provided.

@chrisjenx
Copy link
Owner

Thanks for this, this looks interesting. I've been searching for a better way of building the font families, actually creating Typeface families natively that way we would not need to do any logic ourselves.

@technoir42
Copy link

I would love to see this feature implemented!

@joaofyz
Copy link

joaofyz commented Aug 18, 2015

Very nice feature.

When you plan to release a new version with this?

@mateusgrb
Copy link

Very nice and useful feature!

@swellner
Copy link

swellner commented Jul 6, 2016

This pull request is still open. When you release this feature? Thank you

@vancelopes
Copy link

This would be good on future release. Plz merge

@natario1
Copy link

Any info about this? It’s more than one year old.

@natario1
Copy link

By the way:

  1. The current logic is not 100% compliant with the proposed description in README. For example, if the font is italic, it will look for -RegularItalic, while it should look for -Italic.
  2. As is, it doesn’t work with the default font set in CalligraphyConfig, which is what you would expect. The logic should probably be moved in TypefaceUtils.load(), with some signature changes.

Also if - say - bold is not present we should fallback to regular.

@chrisjenx I have read elsewhere that you were planning to use a different technique. Are you still working on that? Can we help in some way?

@MGaetan89
Copy link

Is there any news regarding this PR or support for setting multiple font types?

@chrisjenx
Copy link
Owner

I would fork and use this yourself, we are going to do another mechanism to do this.

@MGaetan89
Copy link

Thanks for the info.
I can wait for the official solution.
Any (approximate) idea when it will be released?

@MGaetan89
Copy link

@chrisjenx Is there any update on the implementation of this feature?

Copy link

@Manikkumar1988 Manikkumar1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please approve this PR

@chrisjenx
Copy link
Owner

This kind of thing makes more sense to use with either https://github.com/InflationX/ViewPump or the native supported font's built into Google Play Services now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants