Add ignoreClass to Builder #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param viewClass class to be ignored by Calligraphy | ||
| * @return true if class should not be injected, false otherwise | ||
| */ | ||
| public boolean isIgnoredClass(Class<?> viewClass) { |
There was a problem hiding this comment.
This should be on the Utils class as this isn't really a configuration method.
There was a problem hiding this comment.
@chrisjenx where should I store collection of ignored classes if it will be in utils?
There was a problem hiding this comment.
That should be in the Config. Just iterating across the list should not be done inside of the Config. Config should be just immutable state storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iconify projects like (https://github.com/Malinskiy/android-material-icons)[android-material-icons] and (https://github.com/JoanZapata/android-iconify)[android-iconify] have custom TextView classes that should be able to load custom fonts on their own without Calligraphy interfering