Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for italic and bold fonts using attribute textStyle #179

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Support for italic and bold fonts using attribute textStyle #179

wants to merge 7 commits into from

Conversation

gofabian
Copy link

@gofabian gofabian commented Jun 5, 2015

Thanks for this great project. It helped me a lot. Just one thing was missing. Support for bold and italic fonts depending on the attribute textStyle.

I forked gfranks' solution to use the native attribute textStyle for selecting bold/italic fonts.

There have been many redundancies. Therefore I refactored the changes. Additionally I fixed a bug because getTypeface() sometimes returns null.

It would be nice if you could integrate this solution. Let's just discuss about it.

@chrisjenx
Copy link
Owner

Cool, thanks for the PR. I'm not a massive fan of having to define bold/italic etc. It should just work with the textStyle attr.

I'll mull this over when I have more time to spend on it.

@amrbrkt
Copy link

amrbrkt commented Jul 7, 2017

This is really cool, Thanks

@RafaRuiz
Copy link

It's been 5 nice years developing apps for Android, natively, and every time I have to deal with bold/italic, I always end up with a lot of boilerplate code or juniors asking "why should I add fontPath if we didn't add it somewhere else".

Why don't we allow to define default fonts for different Typefaces and override them with fontPath?

It would make our lives really easier.

@chrisjenx
Copy link
Owner

@RafaRuiz My suggestion would be to move to the Calligraphy3 if that is something you still need or use the FontProviders in AndroidX now.

@RafaRuiz
Copy link

My fault.
I didn't realise there was a 3.
Thanks!

@basmaessen
Copy link

When will this branch be merged? Because I'm also having the issue that I want to add multiple styles of a font.

@chrisjenx
Copy link
Owner

@basmaessen it won't be, this fork has no active dev. I would move to https://github.com/InflationX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants