fix: retain unsafe property of Mmap::map in separate function

chmln · Nov 16, 2023 · 559dfcb · 559dfcb
1 parent 601db39
commit 559dfcb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/input.rs b/src/input.rs
@@ -26,8 +26,11 @@ impl Source {
     }
 }
 
-pub(crate) fn make_mmap(path: &PathBuf) -> Result<Mmap> {
-    Ok(unsafe { Mmap::map(&File::open(path)?)? })
+// TODO: memmap2 docs state that users should implement proper
+// procedures to avoid problems the `unsafe` keyword indicate.
+// This would be in a later PR.
+pub(crate) unsafe fn make_mmap(path: &PathBuf) -> Result<Mmap> {
+    Ok(Mmap::map(&File::open(path)?)?)
 }
 
 pub(crate) fn make_mmap_stdin() -> Result<Mmap> {

diff --git a/src/main.rs b/src/main.rs
@@ -42,7 +42,7 @@ fn main() -> Result<()> {
     for source in sources.iter() {
         let maybe_mmap = match source {
             Source::File(path) => if path.exists() {
-                make_mmap(&path)
+                unsafe { make_mmap(&path) }
             } else {
                 Err(Error::InvalidPath(path.clone()))
             },