Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existing tests for changes made as part of the igtools update #96

Open
wants to merge 8 commits into
base: igtools
Choose a base branch
from

Conversation

jranalli
Copy link
Collaborator

@jranalli jranalli commented Sep 30, 2024

This updates the tests for the ideal gas classes to match the basics of the new functionality.

  • Remove the invargs error check (there's not an error with too many invargs anymore)
  • Update the test entropy values for air to match the new entropy calculation including smix
  • Change the h&s and e&s tests to test values rather than testing for them to error

It's important that you merge these tests in, because there are several major functionality-breaking bugs that were introduced in the edits to the ig classes. I have identified many of them and can start to propose fixes, but we've got to update the tests first.

TODO:

  • Write tests for the new igtools module comparable to current state of test_ig at least
  • Incorporate testing of Gibbs & Helmholz and speed of sound for all substances done
  • Look for other tests that have been invalidated double checked, looks ok

@jranalli jranalli changed the title Igtools testsfix Fix existing tests for changes made as part of the igtools update Sep 30, 2024
@jranalli
Copy link
Collaborator Author

Two of the TODO's are sorted out. There are definitely some failed tests in here that indicate bugs. I do have code to address some of them.

@jranalli
Copy link
Collaborator Author

Ok I have a draft of the entire test suite based on your changes completed.

Of 12,541 tests, 2,350 currently fail.

The majority are easy fixes, like a changed variable name that got missed elsewhere, etc, so once we update the tests, we can start addressing those and look at what expansion of the tests is warranted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant