Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ideal Rankine Cycle jupyter notebook tutorial #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adriaan90
Copy link

Good day

I saw in the discussions under the Ideas section the need for a tutorial in the jupyter notebook format. The Ideal Rankine Cycle is an appropriate problem to use to showcase the use of PYroMat.

I am happy to make changes as required by you.

Thank you for the opportunity

Adriaan van Niekerk

@chmarti1
Copy link
Owner

Thanks so much for contributing your code and your time! I won't be able to give it the attention it deserves for a little while. I will. In the meantime, thanks very much for your work, and thanks for using PYroMat!

@adriaan90
Copy link
Author

@chmarti1 I see it has been more than a year since I created the pull request. Please do not hesitate to let me know of any shortfalls that I need to address for this pull request to be successful. Thanks

@chmarti1
Copy link
Owner

It's been a long time - that's true. I've been working to get through the mounting to-do list for the project. These pull requests are still on my to-do list, but they aren't the most urgent yet. Please know I really do value your work. I'm planning to circle around with the rest of the team soon and discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants