Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up GetProfile test #348

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Clean up GetProfile test #348

merged 1 commit into from
Aug 23, 2024

Conversation

mmiranda96
Copy link
Contributor

What does this PR do?

Clean up the GetProfile verification tests. The improvements include:

  • Changing failures to Error instead of Fatal: this way we can run all tests and get all failures on a single run.
    • The first check remains as a Fatal error, as the object might be nil.
  • Change the text on some of the error messages, as they were displaying "version" instead of the proper field checked.
  • Clarify which value was expected and which value was received.

@mmiranda96
Copy link
Contributor Author

@jhand2

@jhand2 jhand2 self-requested a review August 23, 2024 21:52
@jhand2 jhand2 merged commit 52d9c6d into chipsalliance:main Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhand2 jhand2 jhand2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmiranda96 @jhand2