Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all verification tests to use shared test file #224

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

jhand2
Copy link
Collaborator

@jhand2 jhand2 commented Oct 10, 2023

Make it easier to run DPE tests against different targets by putting all the test cases in a test vector file. This allows test infrastructure for a specific target to add required setup and transport code and then execute the tests in a loop.

In particular, this is to support easily running these tests against a Caliptra HwModel target.

Additional fixes:

  • Make hex string conversion use all caps. This matches what Caliptra uses for subject/issuer serialNumber fields.
  • Support encoding X.509 Directory Strings as either PrintableString or UTF8String. This allows more flexibility when specifying issuer encodings.

@jhand2 jhand2 changed the title Move all tests to use shared test file Move all verification tests to use shared test file Oct 10, 2023
zhalvorsen
zhalvorsen previously approved these changes Oct 10, 2023
verification/getCertificateChain.go Outdated Show resolved Hide resolved
verification/tagTCI.go Outdated Show resolved Hide resolved
verification/verification_test.go Show resolved Hide resolved
zhalvorsen
zhalvorsen previously approved these changes Oct 10, 2023
ci.sh Outdated Show resolved Hide resolved
Make it easier to run DPE tests against different targets by putting all
the test cases in a test vector file. This allows test infrastructure
for a specific target to add required setup and transport code and then
execute the tests in a loop.

In particular, this is to support easily running these tests against a
Caliptra HwModel target.

Additional fixes:

* Make hex string conversion use all caps. This matches what Caliptra
  uses for subject/issuer serialNumber fields.
* Support encoding X.509 Directory Strings as either PrintableString or
  UTF8String. This allows more flexibility when specifying issuer
  encodings.
@jhand2 jhand2 merged commit 68800d7 into chipsalliance:main Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants