Change dpe environment to accept DER encoded issuer #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhand2
reviewed
Aug 4, 2023
willyzha
force-pushed
the
issuer_input_fix
branch
2 times, most recently
from
7064bb6
to
d3e0fe5
Compare
jhand2
reviewed
Aug 7, 2023
jhand2
previously approved these changes
Aug 7, 2023
It's difficult to account for different issuer name encoding so rather than DER encoding the issuer from string inputs instead accept a raw DER encoded byte array to place in the certificate.
willyzha
force-pushed
the
issuer_input_fix
branch
from
d3e0fe5
to
3098b97
Compare
jhand2
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's difficult to account for different issuer name encoding in DPE. So rather than DER encoding the issuer from string inputs, instead accept a raw DER encoded byte array to place directly in the DPE certificate.