Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix x509 encoding bugs #127

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix x509 encoding bugs #127

merged 2 commits into from
Jul 25, 2023

Conversation

willyzha
Copy link
Contributor

@willyzha willyzha commented Jul 21, 2023 •
edited
Loading

  • modify RDN encoding of cn and serialnumber attributes into seperate sets
  • change RDN cn encoding type to utf8string

@willyzha
Copy link
Contributor Author

I think we need these changes to correctly encode the cert according to the spec. In particular the tcbinfo part I think we need the extra sequence to properly encode the fwidlist structure which was missing previously.

jhand2
jhand2 reviewed Jul 21, 2023
View reviewed changes
dpe/src/x509.rs Outdated Show resolved Hide resolved
@willyzha
Fix x509 encoding bugs
3053755 
 - modify RDN encoding of cn and serialnumber attributes into seperate sets
 - change RDN cn encoding type to utf8string
@jhand2 jhand2 merged commit 3b9fe71 into chipsalliance:main Jul 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhand2 jhand2 jhand2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willyzha @jhand2