-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: @parcel/source-map default import #157
fix: @parcel/source-map default import #157
Conversation
🦋 Changeset detectedLatest commit: 98f022c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/estransform/build.js
Outdated
js: `import { createRequire as __moduleCreateRequire } from 'module'; | ||
const require = __moduleCreateRequire(import.meta.url); | ||
`, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used npm run build
as a way to test this PR and this is how I found out that this require
is needed in the new output
any other automated tests I can run? I didn't understand it from package.json
or docs, npm test
doesn't seem to do the job
I tested in my repository and the new dist works
fe2286c
to
3337905
Compare
@edoardocavazza I'd really appreciate if you can review this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I have proposed a change that should work the same way, but with (IMO) less complexity.
3337905
to
98f022c
Compare
@edoardocavazza fixed as per your suggestion using |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 90.99% 90.99%
=======================================
Files 39 39
Lines 5928 5929 +1
=======================================
+ Hits 5394 5395 +1
Misses 534 534
☔ View full report in Codecov by Sentry. |
Fixes #155