Add support for disabling VFS caching #86
Merged
+199
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenxiaolong
force-pushed
the
disable-caching
branch
from
a546c45
to
232594b
Compare
VFS caching can now be configured per-remote. Disabling it is equivalent to `rclone mount --vfs-cache-mode none`. This will disable support for random writes and prevent failed uploads from being retried. However, it allows uploads to begin immediately and allows the client to show more accurate file write progress. If a remote type does not support streaming, VFS caching will be force enabled and the UI option will be grayed out. This is preferable to allowing the user to set a broken configuration and not knowing until they try to create a file and having it fail. Internally, RSAF now maintains two sets of VFS instances. One set with caching VFSs and another set with streaming VFSs. This allows the caching option to be toggled immediately without waiting for open files to be closed (and fully uploaded). The downside is that if the user toggles the option while uploads are occurring, the directory listings may be inconsistent until the uploads complete. Issue: #79 Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
force-pushed
the
disable-caching
branch
from
232594b
to
6fc6b98
Compare
chenxiaolong
added a commit
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VFS caching can now be configured per-remote. Disabling it is equivalent to
rclone mount --vfs-cache-mode none. This will disable support for random writes and prevent failed uploads from being retried. However, it allows uploads to begin immediately and allows the client to show more accurate file write progress.If a remote type does not support streaming, VFS caching will be force enabled and the UI option will be grayed out. This is preferable to allowing the user to set a broken configuration and not knowing until they try to create a file and having it fail.
Internally, RSAF now maintains two sets of VFS instances. One set with caching VFSs and another set with streaming VFSs. This allows the caching option to be toggled immediately without waiting for open files to be closed (and fully uploaded). The downside is that if the user toggles the option while uploads are occurring, the directory listings may be inconsistent until the uploads complete.
Issue: #79