Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade fontawesome libs for fix defaultProps warning #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

d4rkm3z
Copy link

@d4rkm3z d4rkm3z commented May 24, 2024

@d4rkm3z
Copy link
Author

d4rkm3z commented May 26, 2024

@supersnager Can you review PR, please?

@pradeepgudipati
Copy link

I guess these changes are ok ! when can we get this changes merged ?

@d4rkm3z
Copy link
Author

d4rkm3z commented Jul 29, 2024

I can't merge this PR because I've not permissions for to do it. I just may comment or close this PR

@robertlugg
Copy link

Please keep open. I don't know the status of this project, but your fix is helpful to me. Thanks.

@vincenttat22
Copy link

@Zakariaels could you approve the pull request to fix the annoying defaultProps warning please? This is a great library but having such issue really makes it less attractive.

@Zakariaels
Copy link

Zakariaels commented Aug 8, 2024

@vincenttat22, I don't have the 'write access' to this repository in order to merge this PR.

@vincenttat22
Copy link

@Zakariaels thanks for the review. I guess only @supersnager can merge this change.
@supersnager Could you please merge and release it? It is just a small dependencies's version update to fix the annoying warning in console.log. Please!

@supersnager
Copy link
Contributor

I will merge it after holidays

@DoaaRadwan
Copy link

@supersnager can you please give a timeframe on when you plan to merge this fix? thanks

@vincenttat22
Copy link

I've been desperately asking the author to merge the change for a month. I really feel like this library has been abandoned.

@2133662-seguin-jonathan
Copy link

Yeah, if it's depreciate that will not do the case. In my case in a student project that can do the case because that heppen when i have already a big part of the interface made. but for professional project that can be not the best thing to have depreciate warning in the console log.

@vincenttat22
Copy link

What a shame! It is a good library. The author could have just merged the pr then problem solved. Why is it too difficult for them to click a button to approve this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants