Finished CRUD for Article #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hardikupadhyay16
commented
Sep 21, 2016
hardikupadhyay16
commented
- Created CRUD for article
- changed column type for long description in article model
KanjariyaHardik
approved these changes
Sep 23, 2016
| @@ -0,0 +1,2 @@ | |||
| json.extract! article, :id, :created_at, :updated_at | |||
| json.url article_url(article, format: :json) | |||
There was a problem hiding this comment.
@hardikupadhyay16 @uzaif313 I think we don't need this at all...
| @@ -0,0 +1 @@ | |||
| json.array! @articles, partial: 'articles/article', as: :article | |||
There was a problem hiding this comment.
Space here at the end of file
| @@ -0,0 +1 @@ | |||
| json.partial! "articles/article", article: @article | |||
There was a problem hiding this comment.
Space here at the end of file
charusat09
reviewed
Sep 28, 2016
| @article = current_user.articles.build(article_params) | ||
| respond_to do |format| | ||
| if @article.save | ||
| if params[:images].present? |
There was a problem hiding this comment.
@uzaif313 can you please extract this code to new private method i.e. save_image(image_param) ?
| respond_to do |format| | ||
| if @article.update(article_params) | ||
| if params[:images].present? | ||
| @article.pictures.destroy_all |
|
@uzaif313 @hardikupadhyay16 @chaudharyprakash Do we need view template any more ?? |
|
@hardikupadhyay16 @uzaif313 @chaudharyprakash also resolve this issue within this branch only.. |
|
this branch is for web not for API |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.