Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTP Support #17

Merged
merged 3 commits into from
Jul 31, 2023
Merged

SMTP Support #17

merged 3 commits into from
Jul 31, 2023

Conversation

maaslalani
Copy link
Contributor

@maaslalani maaslalani commented Jul 26, 2023

Adds SMTP support for pop.

Configured by environment variables:

export POP_SMTP_HOST=smtp.gmail.com
export POP_SMTP_PORT=587
export POP_SMTP_USERNAME=...
export POP_SMTP_PASSWORD=...

If @gmail.com is the suffix of the POP_SMTP_USERNAME then we will automatically set the default of the HOST and PORT to smtp.gmail.com and 587.

@meowgorithm
Copy link
Member

I believe port 587 is now the de-facto standard SMTP port, so perhaps it's worth defaulting to that regardless of whether or not gmail is being used?

@maaslalani
Copy link
Contributor Author

I believe port 587 is now the de-facto standard SMTP port, so perhaps it's worth defaulting to that regardless of whether or not gmail is being used?

Ah nice, good point. Will make it the default 👍

Adds SMTP configuration via environment variables:

* `POP_SMTP_HOST`
* `POP_SMTP_PORT`
* `POP_SMTP_USERNAME`
* `POP_SMTP_PASSWORD`
@maaslalani maaslalani merged commit 7397bcb into main Jul 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants