Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: List "items" method should return instead of setting items #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: List "items" method should return instead of setting items #321

wants to merge 1 commit into from

Conversation

nervo
Copy link
Contributor

@nervo nervo commented Jun 17, 2024

The same way tree has a Child method to set child(ren) and a Children method to return children, list method Items should return items.

Please, take into account that:

  • without this, there is currently no other methods to get list items
  • list Itemans Items methods are currently redundants, as they both set list item(s)
  • this is a breaking change, but list component is not officially released

Fix #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm is a code owner

@muesli muesli Awaiting requested review from muesli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: List should have a method to return its items
1 participant
@nervo